Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#8937] Recent stickers are shown when stickers tab is highlighted #9077

Merged
merged 1 commit into from
Oct 8, 2019
Merged

[#8937] Recent stickers are shown when stickers tab is highlighted #9077

merged 1 commit into from
Oct 8, 2019

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Sep 30, 2019 •
edited by StatusWrike
Loading

fixes #8937

Tested on AVD

@flexsurfer flexsurfer requested a review from a team as a code owner September 30, 2019 12:27
@flexsurfer flexsurfer self-assigned this Sep 30, 2019
@auto-assign auto-assign bot removed the request for review from a team September 30, 2019 12:27
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

vitvly
vitvly approved these changes Sep 30, 2019
View reviewed changes
src/status_im/ui/screens/chat/stickers/views.cljs Outdated
(map-indexed vector installed-packs)))
window-width))]
(.scrollTo ref (clj->js {:x x :animated true})))))
;; bug on Android
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can provide a bit more detail as to why timeout is necessary on Android

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed need more explanation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@status-im-auto
Copy link
Member

status-im-auto commented Sep 30, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (13)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3e549de #1 2019-09-30 12:39:06 ~11 min ios 📦ipa 📲
✔️ 3e549de #1 2019-09-30 12:41:00 ~13 min macos 📦dmg
✔️ 3e549de #1 2019-09-30 12:41:37 ~14 min linux 📦App
✔️ 3e549de #1 2019-09-30 12:42:27 ~15 min windows 📦exe
✔️ 3e549de #1 2019-09-30 12:44:51 ~17 min android 📦apk 📲
✔️ 3e549de #1 2019-09-30 12:46:03 ~18 min android-e2e 📦apk 📲
✔️ f0a4d83 #2 2019-09-30 17:08:57 ~38 min ios 📦ipa 📲
✔️ f0a4d83 #2 2019-09-30 17:10:58 ~40 min macos 📦dmg
✔️ f0a4d83 #2 2019-09-30 17:11:57 ~41 min android-e2e 📦apk 📲
✔️ f0a4d83 #2 2019-09-30 17:13:23 ~42 min windows 📦exe
✔️ f0a4d83 #2 2019-09-30 17:22:45 ~51 min android 📦apk 📲
✔️ f0a4d83 #2 2019-09-30 17:26:22 ~55 min linux 📦App
✔️ f0a4d83 #3 2019-10-08 09:03:44 ~13 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 284f9bf #5 2019-10-08 11:36:37 ~8 min ios 📦ipa 📲
✔️ 4067342 #3 2019-10-08 11:38:27 ~11 min macos 📦dmg
✔️ 4067342 #3 2019-10-08 11:39:01 ~12 min android-e2e 📦apk 📲
✔️ 4067342 #3 2019-10-08 11:40:04 ~13 min android 📦apk 📲

yenda
yenda previously requested changes Sep 30, 2019
View reviewed changes
src/status_im/ui/screens/chat/stickers/views.cljs Outdated
(map-indexed vector installed-packs)))
window-width))]
(.scrollTo ref (clj->js {:x x :animated true})))))
;; bug on Android
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed need more explanation

yenda
yenda reviewed Sep 30, 2019
View reviewed changes
src/status_im/ui/screens/chat/stickers/views.cljs
window-width))]
(.scrollTo ref (clj->js {:x x :animated true})))))
;; bug on Android https://github.com/facebook/react-native/issues/24531
(js/setTimeout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried not update scroll position in component-will-update since it is deprecated anyway? instead do it in component-did-update (L85)

@flexsurfer flexsurfer requested a review from yenda October 1, 2019 09:07
@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
@churik
Copy link
Member

churik commented Oct 8, 2019

@flexsurfer can you please ping me when review comments will be addressed?

@flexsurfer
Copy link
Member Author

@churik it's ready to test

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 47
Failed tests: 1
Passed tests: 46

Failed tests (1)

Click to expand
1. test_send_stt_from_wallet

Device 1: Tap on SendTransactionButton
Device 1: Wait for STTAssetButton

Device 1: 'STTAssetButton' is not found on the screen

Device sessions

Passed tests (46)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_ens_in_public_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_offline_messaging_1_1_chat
Device sessions

20. test_modify_transaction_fee_values
Device sessions

21. test_send_eth_from_wallet_to_address
Device sessions

22. test_add_account_to_multiaccount_instance
Device sessions

23. test_manage_assets
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_can_add_existing_ens
Device sessions

29. test_messaging_in_different_networks
Device sessions

30. test_logcat_backup_recovery_phrase
Device sessions

31. test_logcat_sign_message_from_daap
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_login_with_new_account
Device sessions

34. test_start_chat_with_ens
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_backup_recovery_phrase
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture (TestRail link is not found)
Device sessions

44. test_share_contact_code_and_wallet_address
Device sessions

45. test_refresh_button_browsing_app_webview
Device sessions

46. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@churik
Copy link
Member

churik commented Oct 8, 2019

Tested on IOS and Android:

  • stickers from different stickerpacks
  • max amount of recent stickers
  • recent is preserved after relogin
  • using last / first sticker for recent.

Good job @flexsurfer !

@flexsurfer
[#8937] Recent stickers are shown when stickers tab is highlighted
284f9bf 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit 284f9bf into develop Oct 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/stickers-scroll-android branch October 8, 2019 11:28
@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitvly vitvly vitvly approved these changes

@dmitryn dmitryn Awaiting requested review from dmitryn

@yenda yenda Awaiting requested review from yenda

Assignees
No one assigned
Labels
request-manual-qa Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recent stickers are shown when stickers tab is highlighted
6 participants
@flexsurfer @status-im-auto @churik @statustestbot @vitvly @yenda